Differential D233

Replace homebrew extension matcher with Qt Builtin
ClosedPublic
Actions

Authored by abrahams on Aug 4 2015, 11:34 PM.

Details

Reviewers
dkazakov
rempt
Maniphest Tasks
Restricted Maniphest Task
Commits
R8:e62445c952a2: Replace homebrew extension matcher with Qt Builtin
R37:2edc175efac3: Replace homebrew extension matcher with Qt Builtin
Summary

The functionality of QGLExtensionMatcher has been subsumed in the method
QOpenGLContext::hasExtension(). This replaces several calls to
glGetProcAddress with the Qt versions ctx->getProcAddress, which is able
to catch when these calls are made without an active context.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 516.Aug 4 2015, 11:34 PM
abrahams added a task: Restricted Maniphest Task.
abrahams retitled this revision from to Replace homebrew extension matcher with Qt Builtin.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added reviewers: dkazakov, rempt.
rempt accepted this revision.Aug 5 2015, 9:42 AM
rempt edited edge metadata.

Please push!

krita/ui/opengl/kis_opengl.cpp
107

Do we still need this, if it always returns true?

This revision is now accepted and ready to land.Aug 5 2015, 9:42 AM
Closed by commit R8:e62445c952a2: Replace homebrew extension matcher with Qt Builtin (authored by abrahams). · Explain WhyAug 5 2015, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 520

View Options

krita/ui/opengl/kis_opengl.h

Loading...
View Options

krita/ui/opengl/kis_opengl.cpp

Loading...
View Options

krita/ui/opengl/kis_opengl_canvas2_p.h

Loading...