Generalize the HTML warning box for inline messages
ClosedPublic
Actions

Authored by vkrause on Aug 20 2019, 5:32 PM.

Details

Reviewers

knauss
mlaurent

Commits

Summary

This follows what KMessageWidget or Kirigami.InlineMessage do, making this
visually and conceptually more consistent with everything else.

In here we only need the error message box (for the HTML warning), the
other ones are going to be used by plugins.

While at it, align the visual style for <hr> with Kirigami.Separator.

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Aug 20 2019, 5:32 PM

Looks like this now (on dark color scheme):

This revision is now accepted and ready to land.Aug 20 2019, 9:11 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			messageviewer/src/messagepartthemes/default/autotests/testcsshelper.cpp (6 lines)
M			messageviewer/src/messagepartthemes/default/templates/htmlmessagepart.html (2 lines)
M			messageviewer/src/viewer/csshelper.cpp (14 lines)
M			messageviewer/src/viewer/csshelperbase.h (13 lines)
M			messageviewer/src/viewer/csshelperbase.cpp (74 lines)