Replace obsolete methods in KFourInLine with non-obsolete ones
ClosedPublic

Authored by yurchor on Aug 20 2019, 3:59 PM.

Details

Summary

There are some obsolete methods in the current code (qCopy, qSort and setWorldMatrix). This patch replaces them with common replacements (std::copy, std::sort, and setWorldTransform).

Test Plan
  1. Compile and install KFourInLine. There should be no deprecation warnings with Qt 5.13.
  2. Run kfourinline. Watch demo, play some games. No visible differences should be observed.

Diff Detail

Repository
R395 KFourInLine
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Aug 20 2019, 3:59 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptAug 20 2019, 3:59 PM
yurchor requested review of this revision.Aug 20 2019, 3:59 PM
ognarb added a subscriber: ognarb.Aug 20 2019, 4:10 PM
ognarb added inline comments.
src/kgamepropertyarray.h
282

std::sort( this->begin(), this->end() );

yurchor updated this revision to Diff 64133.Aug 20 2019, 4:19 PM

Use this-> instead of (*this).

yurchor marked an inline comment as done.Aug 20 2019, 4:19 PM

Thanks.

aacid accepted this revision.Aug 20 2019, 5:47 PM
aacid added a subscriber: aacid.
aacid added inline comments.
src/kgamepropertyarray.h
282

could also just be begin() and end(), no this-> needed, but no biggie i guess

This revision is now accepted and ready to land.Aug 20 2019, 5:47 PM
This revision was automatically updated to reflect the committed changes.