Calling KIO::iconNameForUrl will determine mime type of the file potentially blocking.
Don't needless do it when the tab bar isn't visible.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:63c195b7ed9f: [Tab Bar] Resolve tab icon only if visible
Browsed around, all was fine, opened a new tab, the icons were there just fine and updated properly
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Actually, it seems this breaks the build of dolphinmainwindowtest:
../src/tests/dolphinmainwindowtest.cpp:223:21: error: 'tabIcon' is a private member of 'DolphinTabWidget' if (!tabWidget->tabIcon(0).isNull() && !tabWidget->tabIcon(1).isNull()) {