Differential D23292

Make update page labels consistent with topUpdateComp
ClosedPublic
Actions

Authored by MrPepe on Aug 20 2019, 2:20 PM.

Details

Reviewers
ngraham
Group Reviewers
Discover Software Store
Commits
R134:7a2dc6941478: Make update page labels consistent with topUpdateComp
Summary

Made the labels on the update page consistent with the ones shown in the topUpdateComp of the main window

Test Plan

Check for updates and see that the labels have changed

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
MrPepe created this revision.Aug 20 2019, 2:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 20 2019, 2:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
MrPepe requested review of this revision.Aug 20 2019, 2:20 PM
ngraham accepted this revision.Aug 20 2019, 2:22 PM
ngraham added a reviewer: Discover Software Store.
ngraham added a subscriber: ngraham.

How serindipitous; I was just about to do this myself! Needless to say, LGTM.

This revision is now accepted and ready to land.Aug 20 2019, 2:23 PM
MrPepe added a comment.Aug 20 2019, 2:28 PM

This was my first contribution so I was following the wiki guide.
Running ctest showed that knsbackendtest fails. Is that a setup problem on my side or something that actually does not work?

apol added a subscriber: apol.Aug 20 2019, 3:43 PM

Thanks. The problem with the knsbackendtest is most likely unrelated. You can ignore it here.

Do you have permissions to land the patch?

ngraham added a comment.Aug 20 2019, 3:55 PM

@MrPepe I cannot land this patch because our commit hookscript requires a last name in addition to a first name. Can you tell me your last name and adjust your .gitconfig file to include that in future patches?

Thanks!

Closed by commit R134:7a2dc6941478: Make update page labels consistent with topUpdateComp (authored by MrPepe, committed by ngraham). · Explain WhyAug 20 2019, 5:10 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Aug 20 2019, 5:10 PM

Figured it out from your email address. :) Do please update your .gitconfig file for future patches though!

MrPepe added a comment.Aug 21 2019, 2:14 PM

Weird, I actually updated my git config before comitting. Will pay attention to it next time.
Thanks for landing it!

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (10 lines)

Diff 64137

View Options

discover/qml/UpdatesPage.qml

Loading...