Prevent dragging SimpleKCM contents outside view
AbandonedPublic

Authored by GB_2 on Tue, Aug 20, 8:31 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Frameworks
VDG
Summary

You should not be able to drag the contents outside the view, it looks weird. This fixes it.

Test Plan

Open the Fonts KCM and try dragging the contents outside the view. It should not be possible anymore.

Diff Detail

Repository
R296 KDeclarative
Branch
prevent-dragging-simplekcm-contents-outside-view (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15333
Build 15351: arc lint + arc unit
GB_2 created this revision.Tue, Aug 20, 8:31 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Aug 20, 8:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Tue, Aug 20, 8:31 AM
GB_2 edited the test plan for this revision. (Show Details)Tue, Aug 20, 8:31 AM

Can we keep it on mobile?

filipf added a subscriber: filipf.Tue, Aug 20, 8:54 AM

+1 visually

If the behavior is important on mobile let's keep it there of course, but on desktop it feel out of place.

GB_2 updated this revision to Diff 64096.Tue, Aug 20, 9:29 AM

Only affect desktop

davidedmundson accepted this revision.Tue, Aug 20, 12:33 PM
This revision is now accepted and ready to land.Tue, Aug 20, 12:33 PM

+1, but maybe this doesn't go far enough. How about doing it for ScrollablePage instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this.

GB_2 added a comment.Tue, Aug 20, 4:38 PM

+1, but maybe this doesn't go far enough. How about doing it for ScrollablePage instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this.

I will fix it there, but it won't disable click and drag to scroll the view if it's scrollable. It just disables click and drag scroll when there is no scrollbar and disables the scroll overshoot on desktop.

In D23286#515329, @GB_2 wrote:

I will fix it there, but it won't disable click and drag to scroll the view if it's scrollable. It just disables click and drag scroll when there is no scrollbar

Right, that's fine.

and disables the scroll overshoot on desktop.

This would disable it when using a touch swipe or a touchpad on the desktop too though, right? That doesn;t seem desirable. I think we on;y want scroll overshoot disabled when using a scroll wheel; for all other cases, IMO it should be on.

GB_2 added a comment.Tue, Aug 20, 5:48 PM

This would disable it when using a touch swipe or a touchpad on the desktop too though, right? That doesn;t seem desirable. I think we on;y want scroll overshoot disabled when using a scroll wheel; for all other cases, IMO it should be on.

That's how it is now, but click and drag lets you overshoot infinitely.

GB_2 abandoned this revision.Tue, Aug 20, 7:52 PM