Differential D23260

[Battery plasmoid] do not show vendor and product, always show battery details
ClosedPublic
Actions

Authored by meven on Aug 19 2019, 11:44 AM.

Details

Reviewers
broulik
ngraham
Group Reviewers
VDG
Plasma
Commits
R120:df2469e7d238: [Battery plasmoid] do not show vendor and product, always show battery details
Summary

Retry after D23237
Vendor and Product will be shown in the energy information kcm after D23152

Test Plan

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Aug 19 2019, 11:44 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 19 2019, 11:44 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Aug 19 2019, 11:44 AM
broulik accepted this revision.Aug 19 2019, 11:47 AM

Thanks

This revision is now accepted and ready to land.Aug 19 2019, 11:47 AM
meven added a subscriber: alexde.Aug 19 2019, 11:57 AM
In D23260#514394, @broulik wrote:

Thanks

Thank you for catching my screw up and being an attentive maintainer.

@alexde I have kept the capacity in the end as I could not find a better way to display it, and it makes sense especially since the battery details will be shown for all batteries.

ngraham accepted this revision.Aug 19 2019, 2:20 PM
ngraham added a subscriber: ngraham.

Much better, thanks.

Closed by commit R120:df2469e7d238: [Battery plasmoid] do not show vendor and product, always show battery details (authored by meven). · Explain WhyAug 19 2019, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64048

View Options

applets/batterymonitor/package/contents/ui/BatteryItem.qml

Loading...
View Options

applets/batterymonitor/package/contents/ui/logic.js

Loading...