Sample the fits viewer's histogram calculation
ClosedPublic

Authored by murveit on Aug 19 2019, 6:42 AM.

Details

Summary

Fitshistogram previously uses all samples in an image to caculate its
frequency statistics for histogram and statistics displays. This can
take a significant amount of time, and the precision is unnecessary.
With this change, image pixels are sampled when their frequencies are
computed, limited to under 2 million samples. This significantly
speeds up the capture of images when fitsviewer is displaying
statistics or histograms and there are millions of pixels in an image.

Diff Detail

Repository
R321 KStars
Branch
sampling-in-fitshistogram (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15284
Build 15302: arc lint + arc unit
murveit created this revision.Aug 19 2019, 6:42 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 19 2019, 6:42 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Aug 19 2019, 6:42 AM
mutlaqja accepted this revision.Aug 19 2019, 8:08 AM

Great work Hy! I tested this with several images of different resolution and it appears the compromise between sampling and performance is well worth it.

This revision is now accepted and ready to land.Aug 19 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.