Differential D23252

Fix kdepim-addons autotest EnterpriseHeaderStylePluginTest
ClosedPublic
Actions

Authored by gjditchfield on Aug 19 2019, 2:54 AM.

Details

Reviewers
dvratil
Commits
R81:2d8d0a3784b9: Fix kdepim-addons autotest EnterpriseHeaderStylePluginTest
Summary

EnterpriseHeaderStyle::format() returns a chunk of HTML ending with an
unclosed DIV. This patch adds a "</div>" tag in the tests, so that
testHeaderFile() can construct valid XHTML to pass to xmllint, and adds
the DIV to the expected output.

See also D22892.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gjditchfield created this revision.Aug 19 2019, 2:54 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 19 2019, 2:54 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Aug 19 2019, 2:54 AM
dvratil accepted this revision.Aug 19 2019, 8:30 PM
dvratil added a subscriber: dvratil.

Thanks!

This revision is now accepted and ready to land.Aug 19 2019, 8:30 PM
Closed by commit R81:2d8d0a3784b9: Fix kdepim-addons autotest EnterpriseHeaderStylePluginTest (authored by gjditchfield, committed by dvratil). · Explain WhyAug 26 2019, 8:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64644

View Options

plugins/messageviewerheaderplugins/autotests/data/allheaders.mbox.enterprise.html

Loading...
View Options

plugins/messageviewerheaderplugins/autotests/data/empty.enterprise.html

Loading...
View Options

plugins/messageviewerheaderplugins/autotests/data/headertest.mbox.enterprise.html

Loading...
View Options

plugins/messageviewerheaderplugins/autotests/enterpriseheaderstyleplugintest.cpp

Loading...