Sometimes, availableVersion isn't set when the i18n() string is built, leading to ugly
"argument not found" errors. This is an attempt to fix it by not even displaying the
string until both are set.
Details
Details
- Reviewers
apol - Group Reviewers
Discover Software Store - Commits
- R134:1eeacce841d1: Only display old and new versions when both are available
Hard to reproduce, but in my testing, it works.
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Branch
- try-to-fix-i18n-timing-error (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15273 Build 15291: arc lint + arc unit
Comment Actions
This looks like a workaround to me: if installedVersion is not available (is it known when, actually?), why keep using it anyway, with or without i18n?
Also, -1 to string puzzles and to UI strings not translatable.
Comment Actions
Doesn't the visible addition solve it already? We can keep the i18n() call, it will fail in this case but since it's not visible it isn't a big problem anyway.
@pino it's just not available in brief occasions when loading updates.