With this it is not nessecary to KAboutData::setProgramLogo. If the
QApplication::setWindowIcon is set, then the AboutPage will
automatically use that icon.
Details
Details
- Reviewers
mart apol hein - Group Reviewers
Kirigami - Commits
- R169:59a9b92fc6c7: Show application window icon on AboutPage
Tested with Discover, with only setWindowIcon, only setProgramLogo and
both setWindowIcon and setProgramLogo
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- about_icon (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15257 Build 15275: arc lint + arc unit
Comment Actions
I am not sure about the version numbers and the return type. Did I choose the correct ones?
| src/settings.h | ||
|---|---|---|
| 79 | 2.10 actually (this is super confusing, I know) | |
Comment Actions
+1 LGTM, please address the @since bit
| src/settings.h | ||
|---|---|---|
| 81 | It could make sense to include the REVISION part: | |
Comment Actions
I was looking into this recently and added the component name getter, which does the trick for me and is much nicer to use than setting the program logo. So in some sense this is not strictly necessary, and also it would really be better if the window icon was part of the Qt.application upstream API in QML. It's still an okay workaround though. Let's see what Marco thinks.
| src/settings.h | ||
|---|---|---|
| 81 | I have no idea what the value would be for that and Kirigami doesn't have any example. | |
| src/settings.h | ||
|---|---|---|
| 81 | https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions tldr:
I am not sure how that would work for a singletontype though, one always needs all properties since any revision may be used at any time. | |
This comment was removed by bcooksley.
Comment Actions
It looks quite weird to have it in something called "Settings", tough.. i' fine (in kf6 should really be renamed to something more sensible)
I agree with Eike that it would be better for it to be in Qt.Application, but i'm fine with it for now