Vim numbers lines starting from 1. However, in command ranges such as, e.g., 0,$s/foo/bar/g
it accepts zero as a line number and treats it as 1. This commit implements the same behaviour
for kate.
Details
Details
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Seems reasonable, thanks for taking care ;=)
I you use the vi mode, we have more open vi mode bugs that need some love:
(vi input component)
We have some hack to fix one of them here, that needs some research: https://phabricator.kde.org/D19408
Comment Actions
The unittest doesn't seem to pass on CI:
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/
FAIL! : EmulatedCommandBarTest::EmulatedCommandBarTests() Compared values are not the same Actual (kate_document->text()): "bar\nbar\nbar" Expected (expected_text) : "foo\nfoo\nbar" Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)]