Remove all remnants of outdated notification system
ClosedPublic
Actions

Authored by astippich on Aug 17 2019, 3:57 PM.

Details

Reviewers

mgallien
ngraham

Commits

R255:286e46a8b845: Remove all remnants of outdated notification system

Summary

The notification system is not used anywhere
anymore. There is no single emit of
newNotification within Elisa.
If new notifications are added to Elisa, they
should use a PassiveNotification from Kirigami.
More ui cleanup will follow later.

Diff Detail

Repository

R255 Elisa

Branch

removeNotification

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15224
Build 15242: arc lint + arc unit

astippich requested review of this revision.Aug 17 2019, 3:57 PM

astippich created this revision.

Harbormaster completed remote builds in B15224: Diff 63932.Aug 17 2019, 3:57 PM

Let's go. I have not enough time for a proper review but a big +1

This revision is now accepted and ready to land.Aug 17 2019, 4:40 PM

ngraham accepted this revision.Aug 18 2019, 1:14 AM

astippich edited the summary of this revision. (Show Details)Aug 18 2019, 9:19 AM

Closed by commit R255:286e46a8b845: Remove all remnants of outdated notification system (authored by astippich). · Explain WhyAug 18 2019, 9:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/localfilelistingtest.cpp (11 lines)
M		src/CMakeLists.txt (4 lines)
M		src/abstractfile/abstractfilelistener.h (8 lines)
M		src/abstractfile/abstractfilelistener.cpp (5 lines)
M		src/abstractfile/abstractfilelisting.h (7 lines)
M		src/abstractfile/abstractfilelisting.cpp (6 lines)
M		src/android/androidmusiclistener.h (6 lines)
M		src/baloo/localbaloofilelisting.cpp (2 lines)
M		src/elisaimport.cpp (1 line)
M		src/elisaqmlplugin.cpp (4 lines)
M		src/musiclistenersmanager.h (6 lines)
M		src/musiclistenersmanager.cpp (35 lines)
D	M	src/notificationitem.h (87 lines)
D	M	src/notificationitem.cpp (185 lines)
M		src/qml/ContentView.qml (10 lines)
D	M	src/qml/TopNotification.qml (341 lines)
D	M	src/qml/TopNotificationItem.qml (126 lines)
M		src/resources.qrc (2 lines)
D	M	src/topnotificationmanager.h (131 lines)
D	M	src/topnotificationmanager.cpp (201 lines)