Differential D23214

Add a BlockinApp util class to find process blockng access
AbandonedPublic
Actions

Authored by meven on Aug 17 2019, 11:05 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Frameworks

Summary

Uses lsof and kprocesslist to extract names of process blocking on the given files.

It is a port over from ksolidnotify.h of plasma-workspace to allow broader use.

CC D19989

Test Plan

Using testBlockingApp test

Diff Detail

Repository

R244 KCoreAddons

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15212
Build 15230: arc lint + arc unit

meven created this revision.Aug 17 2019, 11:05 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 17 2019, 11:05 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Aug 17 2019, 11:05 AM

Harbormaster completed remote builds in B15212: Diff 63910.Aug 17 2019, 11:05 AM

Add copyright

Harbormaster completed remote builds in B15213: Diff 63911.Aug 17 2019, 11:08 AM

Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.

In D23214#513396, @hallas wrote:

Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.

Great suggestion I missed this prior diff.

Abandoned in favor of D21760 and adding a KJob for this use case

In D23214#513408, @meven wrote:

In D23214#513396, @hallas wrote:

Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 the current suggestion is to look into doing a KJob subclass.

Great suggestion I missed this prior diff.

Abandoned in favor of D21760 and adding a KJob for this use case

I am currently working on re-working the code to derive from KJob, will post an updated patch soon :) Also, please take a look at the code and come with review comments/suggestions :)

Revision Contents
Changeset List

		Path
M		src/lib/CMakeLists.txt (1 line)
A	M	src/lib/util/blockingapp.h (21 lines)
A	M	src/lib/util/blockingapp.cpp (53 lines)
M		tests/CMakeLists.txt (3 lines)
A	M	tests/testblockingapp.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	63910	969e01d		Aug 17 2019, 11:05 AM	★	★
Diff 2	63911	969e01d	Add copyright	Aug 17 2019, 11:08 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
55dae7ec79b6	00e9275216ec	969e01dc8d60	Méven Car	Add a BlockinApp util class to find process blockng access (Show More…)	Aug 17 2019, 11:02 AM

Diff 63910

View Options

src/lib/CMakeLists.txt

View Options

src/lib/util/blockingapp.h

View Options

src/lib/util/blockingapp.cpp

View Options

tests/CMakeLists.txt

View Options

Add a BlockinApp util class to find process blockng accessAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 63910

src/lib/CMakeLists.txt

src/lib/util/blockingapp.h

src/lib/util/blockingapp.cpp

tests/CMakeLists.txt

tests/testblockingapp.cpp

Add a BlockinApp util class to find process blockng access
AbandonedPublic
Actions

Revision Contents
Changeset List