add images to KDE Connect .Appx build
ClosedPublic

Authored by brute4s99 on Aug 16 2019, 9:42 PM.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brute4s99 requested review of this revision.Aug 16 2019, 9:42 PM
brute4s99 created this revision.
vonreth requested changes to this revision.Aug 19 2019, 7:19 PM
vonreth added inline comments.
extragear/kdeconnect-kde/kdeconnect-kde.py
31

please move to createPackage for a better overview

34

sorry didn't see your change, please rebase (see the enw shortcut define from master)

67

Is there display_name? Should be displayname and thats already defined in subinfo.

This revision now requires changes to proceed.Aug 19 2019, 7:19 PM
brute4s99 updated this revision to Diff 64070.Aug 19 2019, 8:09 PM
brute4s99 marked 3 inline comments as done.
brute4s99 retitled this revision from add support for .Appx packages in KDE Connect to add images to KDE Connect .Appx build.
vonreth accepted this revision.Aug 19 2019, 8:21 PM

looks good

This revision is now accepted and ready to land.Aug 19 2019, 8:21 PM
This revision was automatically updated to reflect the committed changes.