Differential D23201

[KDirOperator] Middle-elide labels that are too long to fit
ClosedPublic
Actions

Authored by ngraham on Aug 16 2019, 1:22 PM.

Details

Reviewers

elvisangelaccio

Group Reviewers

VDG

Commits

R241:f05f67d79cad: [KDirOperator] Middle-elide labels that are too long to fit

Summary

Right now too-long labels get right-elided, which among other minor issues, causes
their filename extentions to not be visible. Dolphin is moving to middle-eliding
labels instead (See D19471), so this patch implements the same behavior for KDirOperator
so the file dialogs behave the same way.

CCBUG: 404955

Test Plan

See the Test Plan in D19471; same deal

Diff Detail

Repository

R241 KIO

Branch

middle-elide-kdiroperator-labels (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15178
Build 15196: arc lint + arc unit

ngraham created this revision.Aug 16 2019, 1:22 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 16 2019, 1:22 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Aug 16 2019, 1:22 PM

Harbormaster completed remote builds in B15178: Diff 63860.Aug 16 2019, 1:22 PM

ngraham mentioned this in D19471: Middle-elide file/folder labels so the extension is always visible.Aug 16 2019, 1:22 PM

ngraham edited the summary of this revision. (Show Details)

elvisangelaccio accepted this revision.Aug 24 2019, 4:28 PM

This revision is now accepted and ready to land.Aug 24 2019, 4:28 PM

Closed by commit R241:f05f67d79cad: [KDirOperator] Middle-elide labels that are too long to fit (authored by ngraham). · Explain WhyAug 24 2019, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/filewidgets/kdiroperatordetailview.cpp (7 lines)
M			src/filewidgets/kdiroperatordetailview_p.h (1 line)
M			src/filewidgets/kdiroperatoriconview.cpp (1 line)