Table to fill Precalculated Stats for Two Sample Independent Z-Test
ClosedPublic
Actions

Authored by devanshuagarwal on Aug 15 2019, 4:44 PM.

Details

Reviewers

sgerlach
asemke

Summary

I have tried adding an option (checkbox: "Calculate Statistics from Spreadsheet").

When the user unselects this option then s/he is presented with a "Statistic Table" in Hypothesis Test View. The user then can fill this table with precalculated statistic data and then can press "Recalculate" Button to perform Test.

I have added this feature because, for the test which required huge data, it is possible for user to not have access to data itself but only know statistics of data like Mean, Number of values and Standard Deviation for each column.

Various related screenshots are attached here:

Diff Detail

Repository

R262 LabPlot

Lint

Lint Skipped

Unit

Unit Tests Skipped

devanshuagarwal created this revision.Aug 15 2019, 4:44 PM

devanshuagarwal created this object with edit policy "Administrators".

Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 15 2019, 4:44 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

devanshuagarwal requested review of this revision.Aug 15 2019, 4:44 PM

Thanks in advance for fixing this minor typo.

src/kdefrontend/generalTest/GeneralTestView.cpp
81	Typo: "</h3"); -> "</h3>");

devanshuagarwal marked an inline comment as done.Aug 15 2019, 4:55 PM

devanshuagarwal added inline comments.

src/kdefrontend/generalTest/GeneralTestView.cpp
81	Thanks

Looks already quite good. Just some minor comments from me.

src/backend/generalTest/CorrelationCoefficient.cpp
343	please add a TODO comment if the implementation is not finished
src/backend/generalTest/HypothesisTest.cpp
136	are these cases not implemented yet? If you only consider TwoSampleIndependent please use an if statement.
184	this is set twice, right? If it's constant you can initialize the QStrings with it.

devanshuagarwal marked 3 inline comments as done.Aug 16 2019, 1:57 PM

devanshuagarwal added inline comments.

src/backend/generalTest/HypothesisTest.cpp
184	Not actually. It is set twice with different values based on the block. So there is no use of initializing the two QStrings with some value.

sgerlach added inline comments.Aug 16 2019, 10:05 PM

src/backend/generalTest/HypothesisTest.cpp
184	col1Name="1" and col2Name="2" are inside the for-loop and set twice with the same value or am i missing something?

devanshuagarwal marked 3 inline comments as done.Aug 17 2019, 8:48 AM

devanshuagarwal added inline comments.

src/backend/generalTest/HypothesisTest.cpp
184	Yes, Sorry. I was error. I rectified it now. Thankyou.

devanshuagarwal mentioned this in R262:62b705f0b572: phabricator revision D23189.Aug 18 2019, 8:54 PM

sgerlach accepted this revision.Aug 18 2019, 9:58 PM

This revision is now accepted and ready to land.Aug 18 2019, 9:58 PM

devanshuagarwal closed this revision.Dec 8 2019, 5:40 PM

devanshuagarwal marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			src/backend/generalTest/CorrelationCoefficient.h (4 lines)
M			src/backend/generalTest/CorrelationCoefficient.cpp (9 lines)
M			src/backend/generalTest/GeneralTest.h (5 lines)
M			src/backend/generalTest/GeneralTest.cpp (15 lines)
M			src/backend/generalTest/HypothesisTest.h (5 lines)
M			src/backend/generalTest/HypothesisTest.cpp (83 lines)
M			src/kdefrontend/dockwidgets/CorrelationCoefficientDock.h (1 line)
M			src/kdefrontend/dockwidgets/CorrelationCoefficientDock.cpp (19 lines)
M			src/kdefrontend/dockwidgets/HypothesisTestDock.h (1 line)
M			src/kdefrontend/dockwidgets/HypothesisTestDock.cpp (30 lines)
M			src/kdefrontend/generalTest/GeneralTestView.h (3 lines)
M			src/kdefrontend/generalTest/GeneralTestView.cpp (38 lines)