Differential D23184

[KCM] Draw full QTabWidget frame
ClosedPublic
Actions

Authored by ngraham on Aug 15 2019, 3:31 PM.

Details

Reviewers
davidedmundson
Group Reviewers
VDG
Plasma
Commits
R133:82f198916da1: [KCM] Draw full QTabWidget frame
Summary

Right now we're not drawing the full frame in the Screen Locking KCM to work around
https://bugs.kde.org/show_bug.cgi?id=410943. But this only exchanges one aesthetic
problem for another, and as such, is not an appropriate workaround.

This patch draws the full frame to fix the bug listed below, and then we can concentrate
on fixing https://bugs.kde.org/show_bug.cgi?id=410943 so it works for everyone with
no hacks or workarounds required.

BUG: 410923
FIXED-IN: 5.17.0

Test Plan


Diff Detail

Repository
R133 KScreenLocker
Branch
draw-tabwidget-frame (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15145
Build 15163: arc lint + arc unit
ngraham created this revision.Aug 15 2019, 3:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2019, 3:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 15 2019, 3:31 PM
ngraham edited the summary of this revision. (Show Details)Aug 15 2019, 3:32 PM
ngraham edited the summary of this revision. (Show Details)
davidedmundson accepted this revision.Aug 15 2019, 4:10 PM
This revision is now accepted and ready to land.Aug 15 2019, 4:10 PM
Closed by commit R133:82f198916da1: [KCM] Draw full QTabWidget frame (authored by ngraham). · Explain WhyAug 15 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/kcm.ui (3 lines)

Diff 63813

View Options

kcm/kcm.ui

Loading...