Add finer grained roles for the additional info
ClosedPublic
Actions

Authored by ervin on Aug 15 2019, 2:41 PM.

Details

Reviewers

Commits

R4:ad302efdbb2c: Add finer grained roles for the additional info

Summary

This way we'll move some more of the view logic in the item delegate and
get some more flexibility on the model side. Also move the tests to use
the new roles.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin requested review of this revision.Aug 15 2019, 2:41 PM

ervin created this revision.

Harbormaster completed remote builds in B15142: Diff 63805.Aug 15 2019, 2:41 PM

dfaure accepted this revision.Aug 16 2019, 7:13 AM

dfaure added inline comments.

src/presentation/pagemodel.cpp
106	Hmm, we should really rename childTask to isChildTask. Right now it looks like it points to a child task of info ;)

This revision is now accepted and ready to land.Aug 16 2019, 7:13 AM

Closed by commit R4:ad302efdbb2c: Add finer grained roles for the additional info (authored by ervin). · Explain WhyAug 17 2019, 10:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/presentation/pagemodel.cpp (29 lines)
M			src/presentation/querytreemodelbase.h (4 lines)
M			tests/units/presentation/alltaskspagemodeltest.cpp (25 lines)
M			tests/units/presentation/workdaypagemodeltest.cpp (25 lines)