Avoid partial upgrade on Arch Linux
ClosedPublic

Authored by nhiga on Aug 15 2019, 10:38 AM.

Details

Summary

On Arch Linux, partial upgrades are not supported and users are expected to run pacman -Syu before installing a package, otherwise there may be dependency problems.

BUG: 410915

Diff Detail

Repository
R365 kdesrc-build
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nhiga requested review of this revision.Aug 15 2019, 10:38 AM
nhiga created this revision.
ognarb accepted this revision.Aug 15 2019, 10:51 AM
ognarb added a subscriber: ognarb.

LGTM

This revision is now accepted and ready to land.Aug 15 2019, 10:51 AM

kdesrc-build has moved to GitLab for patches: https://invent.kde.org/kde/kdesrc-build/merge_requests

Would you be able to re-submit this there? Thanks!

@sysadmin I feel like we should really have a way of notifying people who try to submit a patch on Phab when the project has moved to GitLab.

nhiga added a comment.Aug 15 2019, 2:04 PM

kdesrc-build has moved to GitLab for patches: https://invent.kde.org/kde/kdesrc-build/merge_requests

Would you be able to re-submit this there? Thanks!

@sysadmin I feel like we should really have a way of notifying people who try to submit a patch on Phab when the project has moved to GitLab.

OK. By the way, does that mean all KDE projects will eventually move to GitLab?

Yes it does, in fact! Right now we're in a transitional state where a number of apps have moved already, but Plasma and Frameworks and the rest of the apps have not. Over the next few months, we expect to get everything moved over.

I know this is kind of confusing for now; sorry for that.

@ngraham At the moment projects that have opted into Gitlab may still recieve patches via Phabricator, so there isn't a need for that kind of notification at this time.
Once the full migration gets underway, we'll disable the ability to create new reviews on Phabricator as part of the wind down process for reviews on Phabricator.

@ngraham At the moment projects that have opted into Gitlab may still recieve patches via Phabricator, so there isn't a need for that kind of notification at this time.
Once the full migration gets underway, we'll disable the ability to create new reviews on Phabricator as part of the wind down process for reviews on Phabricator.

Managing contributions on two different platforms seems like it's super unfun. Is there any reason not to shut down Phab submissions for projects that have opted into GitLab? It seems like a recipe for the Phab patches to get missed.

With Phabricator, reviews aren't tied to individual projects - they can be associated with multiple projects, or even with no projects (the same way it handles tasks).

Therefore even if it did have an option to do so, it wouldn't be desirable to stop people associating reviews with certain projects as they could still upload them, just not be able to associate them with anything, which would definitely result in them being missed.

Yeah, I guess that makes sense. All the more reason to get everything in GitLab.

nhiga added a comment.Aug 16 2019, 1:09 AM

Then I will leave this patch on KDE Phabricator. Next time, I will submit to GitLab if the project is on KDE GitLab.

By the way, is Valgrind a KDE project? If so, where should Valgrind's patches go to? I notice that Valgrind is using KDE's bug tracker, and contributors filed bug reports to submit their patches, but it seems that patches submitted this way receive little attention.
Some examples:
Bug 408663 - Patch: Suppression file for musl libc
Bug 409206 - PATCH Support for Linux PPS and PTP ioctls
Bug 409391 - PATCH LSE instruction support : LDADD 32bit
Bug 410556 - PATCH add support for BLKIO{MIN,OPT} and BLKALIGNOFF ioctls

Valgrind is an independent project - it only makes use of bugs.kde.org (which it used prior to becoming an independent project)

This revision was automatically updated to reflect the committed changes.