Differential D23164

Improve testPrintD
ClosedPublic
Actions

Authored by adridg on Aug 15 2019, 12:09 AM.

Details

Reviewers
None
Commits
R223:1c1a073c34c0: Improve testPrintD
Summary
  • swap out manual management for a PrintDHelper class that allocates an action and MessageBoxHelper, runs the script, and checks the result.
  • use _data() to run the helper with different data; this improves observability as well.
Test Plan
  • Run tests, see same results as before

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adridg created this revision.Aug 15 2019, 12:09 AM
Restricted Application added a project: Okular. · View Herald TranscriptAug 15 2019, 12:09 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
adridg requested review of this revision.Aug 15 2019, 12:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 3:08 PM
Closed by commit R223:1c1a073c34c0: Improve testPrintD (authored by adridg, committed by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/kjsfunctionstest.cpp (100 lines)

Diff 63811

View Options

autotests/kjsfunctionstest.cpp

Loading...