Use contextually-appropriate icon for GlobalDrawer handle button
ClosedPublic

Authored by ngraham on Aug 14 2019, 7:43 PM.

Details

Summary

Now that the GlobalDrawer's icon can be customized (see D23154), let's use a more
contextually-appropriate icon for Kamoso's GlobalDrawer, which has the effects in it

Test Plan

Diff Detail

Repository
R474 Kamoso
Branch
effects-icon-on-globaldrawer-handle (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15111
Build 15129: arc lint + arc unit
ngraham requested review of this revision.Aug 14 2019, 7:43 PM
ngraham created this revision.
apol accepted this revision.Aug 14 2019, 11:21 PM
This revision is now accepted and ready to land.Aug 14 2019, 11:21 PM

So one concern I have is that it appears a recent ECM change made the frameworks version not get bumped until tagging, so if I commit this now with a 5.62 dep bump, the build will fail for the next three weeks. I suppose I should wait until 5.62 is tagged and the versions get bumped?

ngraham closed this revision.Sat, Sep 7, 8:43 PM