src/controls/OverlayDrawer.qml
110–111	you can write it more compact and avoid code duplication, you can do: if (root.handleClosedIcon.source && root.handleOpenIcon.source) { return Qt.resolvedUrl("templates/private/GenericDrawerIcon.qml"); } else if (edge ==Qt.LeftEdge ) { return Qt.resolvedUrl("templates/private/MenuIcon.qml"); } else if()... ....}
110–111	also, coding style spaces between if an ( and between ) and { if () { }

more compact code and fix coding style spaces

code style spaces

camiloh marked 2 inline comments as done.Aug 14 2019, 4:15 PM

Needs moar @since 5.62

In D23154#511924, @ngraham wrote:

Needs moar @since 5.62

where ?

On the new public properties

it's ok, doesn't add public properties

This revision is now accepted and ready to land.Aug 14 2019, 4:58 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/controls/ContextDrawer.qml (3 lines)
M			src/controls/GlobalDrawer.qml (4 lines)
M			src/controls/OverlayDrawer.qml (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	63737	fd8fec5		Aug 14 2019, 3:37 PM	★	★
Diff 2	63738	fd8fec5	add default handle icon props to null	Aug 14 2019, 3:38 PM	★	★
Diff 3	63740	fd8fec5	more compact code and fix coding style spaces	Aug 14 2019, 4:13 PM	★	★
Diff 4	63742	fd8fec5	code style spaces	Aug 14 2019, 4:15 PM	★	★
Diff 5	63758	56d3ccd	R169:191ff22b1cb9121580abbc7f9baf72c992eb5a56	Aug 14 2019, 7:08 PM	★	★

allow to set custom icon for the left drawer handle
ClosedPublic
Actions

Details