Create new capacity layout - Aether
ClosedPublic

Authored by ognarb on Aug 14 2019, 12:30 PM.

Diff Detail

Repository
R910 Capacity Web Framework
Branch
php7
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15229
Build 15247: arc lint + arc unit
ognarb requested review of this revision.Aug 14 2019, 12:30 PM
ognarb created this revision.

I can't comment too much as to the validity of the HTML/CSS, so will leave that to you, but aside from the one comment above the rest looks okay.

includes/aether/template-bottom2.inc
92 ↗(On Diff #63721)

I wonder if we should do some escaping on this to avoid possible injection issues?

ognarb updated this revision to Diff 63937.Aug 17 2019, 5:32 PM

Escape $_SERVER

ognarb updated this revision to Diff 63938.EditedAug 17 2019, 5:35 PM
ognarb marked an inline comment as done.

Secure $_SERVER in all layouts

bcooksley accepted this revision.Aug 17 2019, 8:09 PM

Thanks for fixing that, codewise this looks fine to me.

This revision is now accepted and ready to land.Aug 17 2019, 8:09 PM
ognarb updated this revision to Diff 63946.Aug 17 2019, 8:11 PM

Last $_SERVER escaping

This revision was automatically updated to reflect the committed changes.