Gettext: fix "previous untranslated string" and other improvements/fixes

Authored by jpoelen on Aug 13 2019, 11:19 PM.


  • fix #| (previous untranslated string)
  • fix hexadecimal entity
  • fix html tag in a < b
  • use <keyword> rather than <RegExpr/StringDetect> for auto-completion
  • string without " at the end of the line is an error
  • # followed by something other than " |:.," is an extension

Diff Detail

R216 Syntax Highlighting
gettext (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 15067
Build 15085: arc lint + arc unit
jpoelen requested review of this revision.Aug 13 2019, 11:19 PM
jpoelen created this revision.
dhaumann accepted this revision.Aug 14 2019, 9:24 AM

Thanks. Removing hardcoded colors would also be nice :-)

This revision is now accepted and ready to land.Aug 14 2019, 9:24 AM
cullmann closed this revision.Aug 15 2019, 8:14 AM

If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version.

If the highlighting still is OK after removing them, sure, but it looks like the language wanted explicitly have different colors for stuff using the same default style. Perhaps one could use some of the new default styles in some places.
And I would always update the version, to allow people to update properly.