Differential D23129

Remove redundant code
ClosedPublic
Actions

Authored by aprcela on Aug 13 2019, 3:49 PM.

Details

Reviewers
meven
elvisangelaccio
Commits
R318:0ab277905885: Remove redundant code
Summary

Remove redundant negation and the AND check. OR is enough.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aprcela created this revision.Aug 13 2019, 3:49 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 13 2019, 3:49 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
aprcela requested review of this revision.Aug 13 2019, 3:49 PM
meven accepted this revision.Aug 13 2019, 4:08 PM
meven added a subscriber: meven.

Legit

This revision is now accepted and ready to land.Aug 13 2019, 4:08 PM
elvisangelaccio added a comment.Aug 13 2019, 8:18 PM

Got the following errore while pushing:

remote: Audit failure - Commit 194ede9f1c175752c17ac9cba49c04b490794b78 - Non-full name: Antonio
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit
remote: error: hook declined to update refs/heads/master

Looks like you need to add a surname to your git config (for example, Antonio Prcela <antonio.prcela@gmail.com>)

aprcela updated this revision to Diff 63681.Aug 13 2019, 9:08 PM

Added my full name in git config.

Closed by commit R318:0ab277905885: Remove redundant code (authored by aprcela, committed by elvisangelaccio). · Explain WhyAug 13 2019, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63682

View Options

src/views/dolphinviewactionhandler.cpp

Loading...