Differential D23118

Changed shortcut for the embedded terminal emulator
ClosedPublic
Actions

Authored by asensi on Aug 12 2019, 9:52 PM.

Details

Reviewers
None
Group Reviewers
Krusader
Commits
R167:083f5a8b3cdd: Changed shortcut for the embedded terminal emulator
Summary

In recent KDE Plasma versions, in a similar way to other desktop environments, the global Ctrl+Alt+T shortcut launches Konsole:

Add a global shortcut (Ctrl+Alt+T) to launch Konsole
https://phabricator.kde.org/D13708

that causes a problem there when a Krusader user presses Ctrl+Alt+T in order to show the embedded terminal emulator. A possible substitute is Ctrl+Alt+E, which is not already taken, and if the user presses Ctrl+Alt+T and sees the problem, he can remember the second letter of "terminal" (or the first letter of "embedded terminal emulator") and press Ctrl+Alt+E.

Test Plan

Execute Krusader, press Ctrl+Alt+T, in e.g. Kubuntu 19.04 see a new Konsole window. Close that window. In Krusader press Ctrl+Alt+E, see the embedded terminal emulator, press Ctrl+Alt+E and see that it hides. Press Ctrl+Alt+E to show the embedded terminal emulator again.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Aug 12 2019, 9:52 PM
asensi created this revision.
asensi retitled this revision from Because Ctrl+Alt+T is now a global shortcut, use another one for the embedded terminal emulator to Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
nmel added a subscriber: nmel.Aug 18 2019, 6:30 AM

Good catch, Toni! No objections for the new shortcut. Please look into

  1. Making the commit headline shorter. Something like "Changed shortcut for the embedded terminal emulator". It's easier to read in the graph view. Please keep everything else, it's very good to have a detailed explanation in the commit message!
  2. Specifying CHANGED: tag, so this is not missed in the ChangeLog on the next release.
asensi added a comment.Sep 1 2019, 5:38 PM

Thanks, Nikita! After asking in the krusader-users mailing list, no objections were made since Aug . 19. The commit will be made.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 5:40 PM
Closed by commit R167:083f5a8b3cdd: Changed shortcut for the embedded terminal emulator (authored by asensi). · Explain Why
This revision was automatically updated to reflect the committed changes.
asensi retitled this revision from Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator to Changed shortcut for the embedded terminal emulator.Sep 1 2019, 5:42 PM

Revision Contents
Changeset List

PathPackages
Mkrusader/kractions.cpp (2 lines)

Diff 65146

View Options

krusader/kractions.cpp

Loading...