target, add multiple datasets
AcceptedPublic

Authored by AkshayCHD on Mon, Aug 12, 8:13 PM.

Details

Summary

Add multiple datasets to target activity

Test Plan

Apply diff on multiple_dataset branch or pull branch gsoc_akshaychd_target_multiple_datasets

Diff Detail

Repository
R2 GCompris
Branch
gsoc_akshaychd_target_multiple_datasets
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15377
Build 15395: arc lint + arc unit
AkshayCHD created this revision.Mon, Aug 12, 8:13 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMon, Aug 12, 8:13 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
AkshayCHD requested review of this revision.Mon, Aug 12, 8:13 PM
AkshayCHD edited the summary of this revision. (Show Details)Mon, Aug 12, 8:15 PM
AkshayCHD edited the test plan for this revision. (Show Details)
AkshayCHD edited projects, added GCompris: Improvements; removed KDE Edu.
AkshayCHD edited subscribers, added: GCompris: Improvements; removed: kde-edu.
Restricted Application added a project: KDE Edu. · View Herald TranscriptMon, Aug 12, 8:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 12, 8:24 PM
This revision was automatically updated to reflect the committed changes.
AkshayCHD reopened this revision.Mon, Aug 12, 8:25 PM
AkshayCHD updated this revision to Diff 63625.Mon, Aug 12, 8:26 PM
AkshayCHD edited the test plan for this revision. (Show Details)
  • target, add lines to end of file

Tested, all works as expected.
There is still the star level associated with the datasets which need to be properly set, as on most of the datasets you added...
Beside this, the rest looks ok.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Aug 20, 7:54 PM
This revision was automatically updated to reflect the committed changes.
AkshayCHD reopened this revision.Tue, Aug 20, 7:55 PM
AkshayCHD updated this revision to Diff 64167.Tue, Aug 20, 7:56 PM
  • target, add lines to end of file
  • target, correct difficulty indicators
timotheegiet accepted this revision.Wed, Aug 21, 12:16 PM

Thanks. To me it looks good.
Though waiting for others comments too.

This revision is now accepted and ready to land.Wed, Aug 21, 12:16 PM