Differential D23110

unbreak http request
ClosedPublic
Actions

Authored by sitter on Aug 12 2019, 12:11 PM.

Details

Reviewers
stikonas
Commits
R472:03c1144efc5f: unbreak http request
Summary

there was a missing space before the HTTP version qualifier, missing a
space there makes the request random garbage as far as the spec (and
in fact most server impls) are concerned and result in broken webseeds
as servers may respond with literally anything seeing as we've made
a request with random garbage

CCBUG: 382375

Test Plan

server starts responding to requests according to wireshark captures

Diff Detail

Repository
R472 KTorrent Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Aug 12 2019, 12:11 PM
sitter created this revision.
stikonas accepted this revision.Aug 12 2019, 7:01 PM
This revision is now accepted and ready to land.Aug 12 2019, 7:01 PM
Closed by commit R472:03c1144efc5f: unbreak http request (authored by sitter). · Explain WhyAug 13 2019, 9:57 AM
This revision was automatically updated to reflect the committed changes.
• fusitter added a subscriber: • fusitter.Aug 29 2019, 3:58 PM

[spam comment removed by sysadmin]

Revision Contents
Changeset List

PathPackages
Msrc/download/httpconnection.cpp (2 lines)

Diff 63649

View Options

src/download/httpconnection.cpp

Loading...