Don't limit it to just check boxes and let the control specify the key to write into.
Check boxes will write their checked state whereas other controls will write their value or a bool for special TRUE or FALSE
Details
Details
- Reviewers
fvogt - Group Reviewers
Plasma - Commits
- R856:c8572d6cbed5: Let settings work with arbitrary input controls
This is in preparation for new features that might use a combo box for some settings
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
extension/options.js | ||
---|---|---|
36–37 | Can be removed? | |
113 | Before it would just ignore that, but now it just creates a new settings key if it didn't exist. Any particular reason? IMO there has to be a default defined for every possible setting anyway. | |
116 | AFAIK we control everything on the settings page already, so why not just convert all of them? | |
119 | console |
extension/options.js | ||
---|---|---|
116 | What do you mean? |
extension/options.js | ||
---|---|---|
116 | <input type="checkbox" data-extension="foo"/> -> <input type="checkbox" data-extension="foo" data-settings-key="enabled"/> and then just error out if there's no key defined. |