Differential D23093

Draw empty arrowheads closed
ClosedPublic
Actions

Authored by davidre on Aug 11 2019, 1:11 PM.

Details

Reviewers
vkrause
Commits
R491:6068b0dc8b80: Draw empty arrowheads closed
Summary

Because drawPolyline will not implicitely close the supplied Polygon
(as drawPolygon does), there was always the last edge of the arrowhead missing.
We have to manually close the Polygon by setting the endpoint to be the
starting point.

Test Plan

Before:


After:

Diff Detail

Repository
R491 KGraphViewer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre requested review of this revision.Aug 11 2019, 1:11 PM
davidre created this revision.
davidre edited the test plan for this revision. (Show Details)Aug 11 2019, 1:12 PM
davidre edited the test plan for this revision. (Show Details)
vkrause accepted this revision.Aug 11 2019, 1:52 PM
This revision is now accepted and ready to land.Aug 11 2019, 1:52 PM
Closed by commit R491:6068b0dc8b80: Draw empty arrowheads closed (authored by davidre). · Explain WhyAug 11 2019, 2:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/part/canvasedge.cpp (1 line)

Diff 63543

View Options

src/part/canvasedge.cpp

Loading...