KRun: remove KProcessRunner dependency on QtWidgets
ClosedPublic

Authored by dfaure on Sun, Aug 11, 12:58 PM.

Details

Summary

The messagebox has moved up to the user of the class, KRun,
via a signal.

The long term plan is to move KProcessRunner to KIOGui, so the future
OpenUrlJob can use it, but KProcessRunner uses KWindowSystem which still
depends on QtWidgets at the moment.

Test Plan

wrote ~/.local/share/applications/appdoesnotexist.desktop
with Exec=appdoesnotexist and MimeType=text/plain;
Started dolphin, RMB on text file, Open With AppDoesNotExist, and the message
box "Could not find the program 'appdoesnotexist'" showed up as expected.

Diff Detail

Repository
R241 KIO
Branch
kprocessrunner
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14980
Build 14998: arc lint + arc unit
dfaure created this revision.Sun, Aug 11, 12:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Aug 11, 12:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sun, Aug 11, 12:58 PM
vkrause accepted this revision.Sun, Aug 11, 1:02 PM
This revision is now accepted and ready to land.Sun, Aug 11, 1:02 PM
dfaure closed this revision.Sun, Aug 11, 1:13 PM