Differential D23089

KWindowSystem: remove unused QWidget includes
ClosedPublic
Actions

Authored by dfaure on Aug 11 2019, 12:28 PM.

Details

Reviewers
broulik
davidedmundson
zzag
Commits
R278:09228717fb36: KWindowSystem: remove unused QWidget includes
Summary

This also gets rid of KWINDOWSYSTEM_NO_QWIDGET

Test Plan

Builds

Diff Detail

Repository
R278 KWindowSystem
Branch
2019_remove_widget_includes_my_master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14979
Build 14997: arc lint + arc unit
dfaure created this revision.Aug 11 2019, 12:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 11 2019, 12:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Aug 11 2019, 12:28 PM
zzag accepted this revision.Aug 11 2019, 1:32 PM

"KWindowSystem:" can be omitted in the subject line.

src/platforms/xcb/kwindowsystem.cpp
28

coding stykle nitpick: Each section is sorted alphabetically. :-)

This revision is now accepted and ready to land.Aug 11 2019, 1:32 PM
dfaure added a comment.Aug 11 2019, 2:02 PM
In D23089#510276, @zzag wrote:

"KWindowSystem:" can be omitted in the subject line.

That's for the benefit of the kde-frameworks-devel mailing list where it's all a bit mixed up otherwise...

dfaure closed this revision.Aug 11 2019, 2:02 PM
zzag added a comment.Aug 11 2019, 2:03 PM
In D23089#510308, @dfaure wrote:

That's for the benefit of the kde-frameworks-devel mailing list where it's all a bit mixed up otherwise...

Oh, I didn't know that. Thank you for the clarification. :-)

Revision Contents
Changeset List

Diff 63531

View Options

src/kwindoweffects.h

Loading...
View Options

src/platforms/xcb/kselectionowner.cpp

Loading...
View Options

src/platforms/xcb/kwindowsystem.cpp

Loading...
View Options

src/platforms/xcb/netwm.h

Loading...