KWindowSystem: add setNewStartupId(QWindow *...) overload
ClosedPublic

Authored by dfaure on Sun, Aug 11, 11:18 AM.

Details

Summary

and deprecate the QWidget * overload, so that we can get rid of the
QtWidgets dependency one day.

Test Plan

Builds, new test passes

Diff Detail

Repository
R278 KWindowSystem
Branch
2019_setNewStartupId
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14978
Build 14996: arc lint + arc unit
dfaure created this revision.Sun, Aug 11, 11:18 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Aug 11, 11:18 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sun, Aug 11, 11:18 AM

vladz has no phab account?

dfaure updated this revision to Diff 63530.Sun, Aug 11, 12:22 PM

Add test for QWidget overload and fix crash

I found out a comment in KWindowSystem::setMainWindow which said this was necessary
(urgh, bad API), so doing the same here, after the unittest showed that windowHandle()
is indeed nullptr otherwise.

If this commit is OK, then KWindowSystem::setMainWindow() is the (only) other one
which will need similar treatment.

zzag accepted this revision.Sun, Aug 11, 1:39 PM
This revision is now accepted and ready to land.Sun, Aug 11, 1:39 PM
dfaure closed this revision.Sun, Aug 11, 2:04 PM