Do not match daemonized dolphin instances: part 2
ClosedPublic

Authored by elvisangelaccio on Sun, Aug 11, 10:18 AM.

Details

Summary

dolphin --daemon does not have the /dolphin/Dolphin_1 dbus path,
because it doesn't have any DolphinMainWindow.

Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors.

This should have been part of commit 7df5fc8edb54153f. Not sure how I missed it.

BUG: 408244
FIXED-IN: 19.08.0

Test Plan
  1. Make sure the new "Open new folders in tabs" setting is enabled.
  2. Run dolphin --deamon and make sure is the only dolphin process around.
  3. Call the org.freedesktop.FileManager1.ShowFolders method from QDbusViewer.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptSun, Aug 11, 10:18 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Sun, Aug 11, 10:18 AM
feverfew accepted this revision.Sun, Aug 11, 11:02 AM

Can't test, but looks sane to me. I have a small comment, but can be left for later if time is of the essence.

src/global.cpp
107–110

I think now it would be appropriate to change this to read the same as L93-95.

This revision is now accepted and ready to land.Sun, Aug 11, 11:02 AM
This revision was automatically updated to reflect the committed changes.
src/global.cpp
107–110