[GTK3 -> Chrome/ium] Tweak tab stylings
ClosedPublic

Authored by cblack on Sun, Aug 11, 1:25 AM.

Details

Summary

Tabs have had their colors changed to make it easier to tell which is active.

BUG: 403108

Test Plan

Breeze Normal:
Breeze Dark:
Breeze Light:

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sun, Aug 11, 1:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Aug 11, 1:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sun, Aug 11, 1:25 AM
cblack edited the test plan for this revision. (Show Details)Sun, Aug 11, 1:26 AM

TBH I don't like it with the standard Breeze color scheme--or any color scheme where the titlebar is a bold or highly contrasting color. The top part of the window starts to feel overwhelming IMO. I think it looks out of place with other windows where that area of color is much smaller.

Could we make the tab bar background and inactive tabs have better contrast with the active tabs without going this far?

cblack edited the summary of this revision. (Show Details)Sun, Aug 11, 3:21 AM

+1 to making tabs easier to see. I had to stop using Chome in GTK theme mode but use Chrome's default theme as with Breeze GTK I just couldn't tell them apart.

+100000 to the original contrasted version
The other variant with dark toolbar just looks weird. If I use Breeze light I want light controls, light address bar and favorites.

cblack updated this revision to Diff 63559.Sun, Aug 11, 5:58 PM

Add some extra colors + backdrop colors

cblack edited the test plan for this revision. (Show Details)Sun, Aug 11, 6:01 PM
cblack edited the test plan for this revision. (Show Details)Sun, Aug 11, 6:03 PM
cblack edited the test plan for this revision. (Show Details)Sun, Aug 11, 6:05 PM

Now it's is literally impossible to tell which tab is active when the window is inactive with the default Breeze color scheme:

This doesn't happen with all color schemes I tested but it's a problem with Breeze.

I'm uneasy approving a change that is so dependent on the user's color scheme to look good--especially if it has problems with the default color scheme. For any color scheme where the titlebar is strongly contrasting with the window background, the top of the window just looks super duper overwhelming to me. It results in a look we have anywhere else and with the default Breeze color scheme I think it looks super heavy:

The only color schemes I can find where I think it looks good are light ones like Breeze Light, Breath, and Materia Light:

Breeze light:


Breath:

Materia light:

It results in a look we have anywhere else and with the default Breeze color scheme I think it looks super heavy:

This looks absolutely fantastic.

All of the light options you like lack contrast to the disabled tabs. The main reason I had to stop using Breeze GTK in Chrome is that inactive tabs have the same color as the current one making it hard to see which is the current tab.

Maybe we need to take step back and come up with a solution that works for all schemes, even if it means tinting the user color for this particular control (if that's possible with CSS).

IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget:

Not too contrasty, but not too subtle either.

IMO the ideal state of affairs would be to somehow emulate the colors of the standard Qt tab widget:

Not too contrasty, but not too subtle either.

+1, we should try to match breeze.

cblack updated this revision to Diff 63661.Tue, Aug 13, 2:06 PM

Change around the colors a bit

cblack edited the test plan for this revision. (Show Details)Tue, Aug 13, 2:08 PM

I'm aware of the visibility issues of the window buttons on Breeze light CSD, however fixing those would require changes outside of the scope of this patch.

ngraham accepted this revision.Tue, Aug 13, 2:15 PM

Perfect. I agree, we can fix the windeco buttons in another patch.

This revision is now accepted and ready to land.Tue, Aug 13, 2:15 PM
GB_2 accepted this revision.Tue, Aug 13, 2:27 PM
This revision was automatically updated to reflect the committed changes.