Differential D23064

Fix duplicate results when a 2nd unit is partially written in krunner
ClosedPublic
Actions

Authored by iasensio on Aug 10 2019, 8:22 AM.

Details

Reviewers
ngraham
broulik
Commits
R114:239f574c5b2f: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner
Summary

When typing a conversion, and the second unit is partially written (i.e. "10€ to ru..." the results are duplicated by several times. This behavior happens with different categories of units (lenght, currency, ...) and on different languages.

The problem is that a new result is being added not once for every matching unit, but once for every matching stringUnit, generating the duplicates.

Before:

After:

This is my first attempt to build kde from source and commit the diff to phabricator, so please excuse any possible mistakes.

BUG: 410744

Test Plan

Open krunner and type any conversion with a letter for the second unit: "10€ to r"
Result for each matching second unit is only shown one time

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
iasensio created this revision.Aug 10 2019, 8:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 10 2019, 8:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
iasensio requested review of this revision.Aug 10 2019, 8:22 AM
broulik accepted this revision.Aug 10 2019, 2:18 PM

Well done! :)
I'll land this (or Nate is probably quicker) once I find the time to do it. Can I use the email address you used in the bugreport for this?

This revision is now accepted and ready to land.Aug 10 2019, 2:18 PM
ngraham accepted this revision.Aug 10 2019, 2:27 PM

I'll do it :)

Very nice job indeed!

ngraham retitled this revision from Fix #410744: Duplicate results when a 2nd unit is partially written in krunner to Fix duplicate results when a 2nd unit is partially written in krunner.Aug 10 2019, 2:30 PM
iasensio added a comment.Aug 10 2019, 2:32 PM

Sure about the email. Thanks!

Closed by commit R114:239f574c5b2f: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner (authored by iasensio, committed by ngraham). · Explain WhyAug 10 2019, 3:48 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Aug 10 2019, 7:15 PM

Great job, @iasensio! May it be the first of many. :)

Revision Contents
Changeset List

Diff 63456

View Options

runners/converter/converterrunner.cpp

Loading...