Use new Kirigami ListSectionHeader component on Updates and Sources pages
ClosedPublic
Actions

Authored by ngraham on Aug 9 2019, 5:39 PM.

Details

Reviewers

apol
GB_2

Group Reviewers

Discover Software Store
VDG

Maniphest Tasks

T10384: Unify styles for lists and their buttons

Commits

R134:296847184e07: Use new Kirigami ListSectionHeader component on Updates and Sources pages

Summary

This allows all the section headers to always have the same look and feel and be
adjusted in just one place.

Depends on D23049

Test Plan

Updates page:

Sources page: no visual or functional changes

Diff Detail

Repository

R134 Discover Software Store

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Aug 9 2019, 5:39 PM

Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2019, 5:39 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.Aug 9 2019, 5:39 PM

Harbormaster completed remote builds in B14922: Diff 63439.Aug 9 2019, 5:39 PM

ngraham mentioned this in D23058: Reduce visual strength of version numbers on Updates page.Aug 9 2019, 5:53 PM

Also port the Sources page headers

Harbormaster completed remote builds in B14927: Diff 63445.Aug 9 2019, 7:18 PM

ngraham retitled this revision from Use new Kirigami ListSectionHeader component on Updates page to Use new Kirigami ListSectionHeader component on Updates and Sources pages.Aug 9 2019, 7:19 PM

ngraham edited the test plan for this revision. (Show Details)

apol accepted this revision.Aug 12 2019, 11:34 AM

This revision is now accepted and ready to land.Aug 12 2019, 11:34 AM

GB_2 accepted this revision.Aug 12 2019, 12:01 PM

ngraham mentioned this in R134:e576f8a69349: Reduce visual strength of version numbers on Updates page.Aug 14 2019, 11:58 PM

Closed by commit R134:296847184e07: Use new Kirigami ListSectionHeader component on Updates and Sources pages (authored by ngraham). · Explain WhySep 8 2019, 2:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			discover/qml/SourcesPage.qml (119 lines)
M			discover/qml/UpdatesPage.qml (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	63439	9e0c7f3		Aug 9 2019, 5:39 PM	★	★
Diff 2	63445	9e0c7f3	Also port the Sources page headers	Aug 9 2019, 7:18 PM	★	★
Diff 3	65627	d6ea8f2	R134:296847184e0701bf90e94243729216e9b3b3d2ee	Sep 8 2019, 2:33 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
0a1e82dcf493	feab553c10d3	9e0c7f34cc02	Nate Graham	Use new Kirigami ListSectionHeader component on Updates page (Show More…)	Aug 9 2019, 5:36 PM

Status	Author	Revision
Closed	ngraham	D23052 [Sidebar] Use new Kirigami ListSectionHeader component
Closed	ngraham	D23054 [Notifications] Use new Kirigami ListSectionHeader component in KCM's sources page
Closed	ngraham	D23055 [kcmkwin/kwindesktop] Use new Kirigami ListSectionHeader component
Closed	ngraham	D23057 Use new Kirigami ListSectionHeader component on Updates and Sources pages
Closed	GB_2	D23049 Add Kirigami ListSectionHeader component

Diff 65627

View Options

CMakeLists.txt

View Options

discover/qml/SourcesPage.qml

View Options

discover/qml/UpdatesPage.qml

Use new Kirigami ListSectionHeader component on Updates and Sources pagesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 65627

CMakeLists.txt

discover/qml/SourcesPage.qml

discover/qml/UpdatesPage.qml

Use new Kirigami ListSectionHeader component on Updates and Sources pages
ClosedPublic
Actions

Revision Contents
Changeset List