RFC: Don't auto-restart KRunner when crashed
ClosedPublic

Authored by broulik on Aug 9 2019, 5:13 PM.

Details

Summary

It is automatically started when invoked.

Test Plan

I don't remember anymore but David had some concern with this, hence as RFC, just so I don't forget

  • killall -6 krunner, got a DrKonqi, now also with a notification (which might have been what David was referring to), hit Alt+Space, KRunner restarted

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 9 2019, 5:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2019, 5:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 9 2019, 5:13 PM

I like the idea, I have krunner crashing every so often, but usually it manages to restart, so I never look into that. Getting a backtrace would make fixing it much more likely.

davidedmundson accepted this revision.Aug 21 2019, 10:01 AM
davidedmundson added a subscriber: davidedmundson.

which might have been what David was referring to

Yeah, it was.
I'd like us to find a way to make that behaviour choosing explicit not inferred from restart behaviour as it's something that affects other cases.

This can still go in though.

This revision is now accepted and ready to land.Aug 21 2019, 10:01 AM
This revision was automatically updated to reflect the committed changes.