Differential D23042

When implementing assignment, also implement copy ctor
ClosedPublic
Actions

Authored by gladhorn on Aug 9 2019, 12:59 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R119:937a0cedf227: When implementing assignment, also implement copy ctor
Summary

/plasma-desktop/kcms/keyboard/xkb_rules.cpp: In static member function ‘static Rules::GeometryId Rules::getGeometryId(const QString&)’:
/plasma-desktop/kcms/keyboard/xkb_rules.cpp:426:16: warning: implicitly-declared ‘Rules::GeometryId::GeometryId(const Rules::GeometryId&)’ is deprecated [-Wdeprecated-copy]

426 |         return defaultGeoId;
    |                ^~~~~~~~~~~~

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Aug 9 2019, 12:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2019, 12:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Aug 9 2019, 12:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2019, 7:09 PM
Closed by commit R119:937a0cedf227: When implementing assignment, also implement copy ctor (authored by gladhorn). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/keyboard/xkb_rules.h (3 lines)

Diff 63499

View Options

kcms/keyboard/xkb_rules.h

Loading...