Differential D23041

Fix some compiler warnings
ClosedPublic
Actions

Authored by schwarzer on Aug 9 2019, 12:23 PM.

Details

Reviewers

dakon

Summary

While looking for something else, I got rid of some of the warnings, the compiler gave me here.

Test Plan

Compiles.

Diff Detail

Repository

R363 Print Manager

Lint

Lint Skipped

Unit

Unit Tests Skipped

schwarzer created this revision.Aug 9 2019, 12:23 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptAug 9 2019, 12:23 PM

schwarzer requested review of this revision.Aug 9 2019, 12:23 PM

dakon added a subscriber: dakon.Aug 9 2019, 12:30 PM

dakon added inline comments.

add-printer/AddPrinter.cpp
36 ↗	(On Diff #63400)	Can you initialize this directly in the class?

schwarzer added inline comments.Aug 9 2019, 2:30 PM

add-printer/AddPrinter.cpp
36 ↗	(On Diff #63400)	Of course. :)

init member in header

I think I updated to a new diff but it is not showing the new changes ... Any hint?

My bad, this should now be the right diff.

Any more complaints/suggestions? I do not know who would be a good assignee for print-manager since several people more or less sporadically work on it.

Since noone else steps in, I'll put my module maintainer head on.

This revision is now accepted and ready to land.Aug 14 2019, 7:47 PM

Committed as 5f29c43e896e7865de7a6a7ee747f6ffc60f47dc

Revision Contents
Changeset List

			Path	Packages
M			add-printer/AddPrinter.h (2 lines)
M			add-printer/ChooseLpd.cpp (3 lines)
M			add-printer/ChooseSamba.cpp (1 line)
M			add-printer/ChooseSerial.cpp (3 lines)
M			add-printer/ChooseSocket.cpp (1 line)
M			add-printer/ChooseUri.cpp (1 line)
M			add-printer/DevicesModel.cpp (2 lines)
M			add-printer/PageAddPrinter.cpp (6 lines)
M			add-printer/PageChoosePPD.cpp (5 lines)
M			add-printer/PageChoosePrinters.cpp (8 lines)
M			add-printer/PageDestinations.cpp (7 lines)