In my experience it has these advantages:
- harder type checks,
- allows to use = default ctor,
- simplify ctors.
// I hope this time, I've created "ok" diff.
Lint Skipped |
Unit Tests Skipped |
Did you make these changes manually, or use clang-tidy for it?
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-default-member-init.html
Personally, I would prefer the = member init syntax over the braced initialization. This is how we did it in most other cases already as well where we use in-class member initialization.
@gawin: hello; how are you creating the diff? if you haven't used arc diff, that could be one reason why the commit authorship is messed up.
Note there's this UseAssignment option in the clang-tidy checker you can (and should) use. Just trying to preserve you from having to go through the diff manually :)
I've tried to use arc for this. It created new PR. https://phabricator.kde.org/D23351