[notifications] Remove unread counter, use icon instead
ClosedPublic

Authored by ndavis on Aug 8 2019, 5:52 AM.

Details

Summary

Text inside a small circle has a lot of problems with fitting in there
and being properly aligned.

Test Plan

Breeze:

Breeze (with D23019):

Air:

Oxygen:

Diff Detail

Repository
R120 Plasma Workspace
Branch
notification-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14861
Build 14879: arc lint + arc unit
ndavis created this revision.Aug 8 2019, 5:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2019, 5:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Aug 8 2019, 5:52 AM
ndavis edited the test plan for this revision. (Show Details)Aug 8 2019, 5:59 AM
ndavis updated this revision to Diff 63331.Aug 8 2019, 6:09 AM
  • Undo DND icon change

    For some reason, the new icon is displayed at larger size than the original even though they should be exactly the same.
broulik added a subscriber: broulik.Aug 8 2019, 6:55 AM

Can you test with other themes, like Air, and maybe some common third party ones.

ndavis edited the test plan for this revision. (Show Details)Aug 8 2019, 7:11 AM
ndavis updated this revision to Diff 63336.Aug 8 2019, 7:15 AM
  • Hide label by default

    Sometimes it likes to show up either over or under the icon

+1
Seems to work fine even with the old icons, except maybe the default state is now black instead of the usual gray. But given the unread notifications case is blue now, should be alright.
Also works well with Air, Adapta, Arc.
Except for the do not disturb icon mixup in D23019 I think this works better than I anticipated, good job!

ngraham accepted this revision.Aug 8 2019, 6:18 PM
ngraham added a subscriber: ngraham.

LGTM for Plasma 5.17 in conjunction with whatever gets decided for D23019.

This revision is now accepted and ready to land.Aug 8 2019, 6:18 PM
ndavis updated this revision to Diff 63373.Aug 8 2019, 7:24 PM
  • Don't change default icon

I'll put this in a separate patch so that it can be landed on stable.

ndavis edited the test plan for this revision. (Show Details)Aug 8 2019, 10:19 PM
ndavis edited the test plan for this revision. (Show Details)Aug 8 2019, 10:23 PM
ndavis retitled this revision from [notifications] Remove unread counter, use icons instead to [notifications] Remove unread counter, use icon instead.Aug 8 2019, 11:19 PM
ndavis edited the summary of this revision. (Show Details)
ngraham accepted this revision.Aug 8 2019, 11:22 PM

LGTM for master branch.

This revision was automatically updated to reflect the committed changes.