[KRDB] Fix wrong names in GTK colordef exports
ClosedPublic

Authored by cblack on Aug 7 2019, 2:34 PM.

Details

Summary

The background & foreground color states of the button color variants were exporting to the wrong name. This revision changes the names to the ones used by Breeze GTK.

Test Plan

Ensure that the button variant colors export properly now (backdrop [unfocused window], insensitive [disabled])

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-colordef-names (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14837
Build 14855: arc lint + arc unit
cblack created this revision.Aug 7 2019, 2:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 7 2019, 2:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Aug 7 2019, 2:34 PM
cblack edited the summary of this revision. (Show Details)Aug 7 2019, 2:34 PM
cblack updated this revision to Diff 63277.Aug 7 2019, 2:40 PM

Fix foreground color names

cblack edited the summary of this revision. (Show Details)Aug 7 2019, 2:40 PM
ngraham added a subscriber: ngraham.Aug 7 2019, 3:04 PM

Could you attach before-and-after pictures showing what was broken and how it's fixed now? That's very helpful with this kind of patch where you may be more of a subject matter expert than your reviewers. :)

cblack edited the test plan for this revision. (Show Details)Aug 7 2019, 3:24 PM
ngraham accepted this revision.Aug 7 2019, 4:07 PM
This revision is now accepted and ready to land.Aug 7 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.