Fix build with cmake < 3.7
ClosedPublic

Authored by wbauer on Aug 7 2019, 10:52 AM.

Details

Summary

VERSION_GREATER_EQUAL was introduced in cmake 3.7, but the specified minimum version is 2.8.12.
So use NOT VERSION_LESS instead to still support older cmake versions too.

Test Plan

Builds fine with cmake 3.5.2 now, and also newer versions.
The file is still installed to ${KDE_INSTALL_LOGGINGCATEGORIESDIR} when building with latest KF5 from git, haven't tried older versions.

Before, I got this error when using cmake 3.5.2:

CMake Error at CMakeLists.txt:100 (if):
  if given arguments:

    "ECM_VERSION" "VERSION_GREATER_EQUAL" "5.59.0"

  Unknown arguments specified

Diff Detail

Repository
R443 KImageMapEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer requested review of this revision.Aug 7 2019, 10:52 AM
wbauer created this revision.
aacid accepted this revision.Aug 7 2019, 5:10 PM
This revision is now accepted and ready to land.Aug 7 2019, 5:10 PM
This revision was automatically updated to reflect the committed changes.