Use origin from filterCookie as cookie URL if possible
Needs ReviewPublic
Actions

Authored by stefanocrocco on Aug 7 2019, 10:00 AM.

Details

Summary

Use the URL passed to filterCookie as cookie origin

This needs to be stored so that removeCookie can access it.

The URL of cookies loaded by KCookieServer at startup are also stored

Rewrite WebEnginePartCookieJar::constructUrlForCookie

Add tests for new way of constructing URLs for cookies

Add test to ensure cookies URLs are stored on startup

Repository

R226 Konqueror

Branch

cookies-origin-with-cookie-filter

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14832
Build 14850: arc lint + arc unit

stefanocrocco requested review of this revision.Aug 7 2019, 10:00 AM

stefanocrocco created this revision.

			Path	Packages
M			webenginepart/autotests/webenginepartcookiejar_test.h (21 lines)
M			webenginepart/autotests/webenginepartcookiejar_test.cpp (204 lines)
M			webenginepart/src/webenginepartcookiejar.h (16 lines)
M			webenginepart/src/webenginepartcookiejar.cpp (63 lines)

Commit	Tree	Parents	Author	Summary	Date
7ae5d78d1ed7	2330a4c03739	9411da88129a	Stefano Crocco	Add test to ensure cookies URLs are stored on startup	Aug 5 2019, 9:28 AM
9411da88129a	f3cb1b2d814c	7bb7e99073f5	Stefano Crocco	Add tests for new way of constructing URLs for cookies	Aug 4 2019, 12:35 PM
7bb7e99073f5	d54ab5f27bf1	a13698087f17	Stefano Crocco	Rewrite WebEnginePartCookieJar::constructUrlForCookie	Aug 4 2019, 12:33 PM
a13698087f17	31d58f0d4c4a	dd253421629e	Stefano Crocco	Use the URL passed to filterCookie as cookie origin (Show More…)	Aug 2 2019, 9:41 AM
dd253421629e	542cef3b8223	f2a6cc2af795	Stefano Crocco	Use origin from filterCookie as cookie URL if possible	Jul 10 2019, 9:58 AM