Differential D22981

Minor code improvements
ClosedPublic
Actions

Authored by filipf on Aug 7 2019, 1:21 AM.

Tags

Subscribers

Details

Reviewers

davidedmundson
ngraham

Group Reviewers

Commits

R123:c1c4e03b0003: Minor code improvements

Summary

more debugging
more comments
for two buttons emit toggled instead of clicked regarding changed
add authorship info

Test Plan

it compiled and still worked

Diff Detail

Repository

R123 SDDM Configuration Panel (KCM)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

filipf created this revision.Aug 7 2019, 1:21 AM

Restricted Application added a project: Plasma. · View Herald TranscriptAug 7 2019, 1:21 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

filipf requested review of this revision.Aug 7 2019, 1:21 AM

Harbormaster completed remote builds in B14828: Diff 63249.Aug 7 2019, 1:21 AM

filipf edited the test plan for this revision. (Show Details)Aug 7 2019, 1:23 AM

filipf added reviewers: davidedmundson, ngraham, Plasma.

ngraham accepted this revision.Aug 7 2019, 1:46 AM

This revision is now accepted and ready to land.Aug 7 2019, 1:46 AM

also show debug output if scaling DPI is not found

Harbormaster completed remote builds in B14829: Diff 63250.Aug 7 2019, 2:17 AM

davidedmundson accepted this revision.Aug 10 2019, 6:03 PM

Closed by commit R123:c1c4e03b0003: Minor code improvements (authored by filipf). · Explain WhyAug 10 2019, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			sddmauthhelper.h (1 line)
M			sddmauthhelper.cpp (6 lines)
M			src/advanceconfig.h (3 lines)
M			src/advanceconfig.cpp (80 lines)

Diff 63503

sddmauthhelper.h

Loading...

sddmauthhelper.cpp

Loading...

src/advanceconfig.h

Loading...

src/advanceconfig.cpp

Loading...