Thanks putting this here is fine for now

This looks fine to me and fixes the issue.

Thanks everyone. I forgot to say, I don't have write access to the repository, so I'd be thankful if someone could push it.

And btw, silly question, but does Phabricator retain authorship? I just downloaded the diff from my work computer to make Konsole work there too, and I figured that diff is not in patch format.

I mean, I don't see my description of the commit, nor I see commit id, author, Date — nothing. Not only in diff, but not in here too. This is odd, so I thought it might be nice idea to ask about it.

FTR, I just remember I pushed this commit on github too, here's how it looks there https://github.com/Hi-Angel/konsole/commit/5fdedf795c98053e15f7edbc25193f57a859f8d5

Though in retrospective, the title here is better than the one in commit. However lack of description and authorship here bothers me. The part that this change should not affect menu accelerators, for example, seems important.

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

In D22980#508391, @hiangel wrote:

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

/phabricator.kde.org/ will eventually be retired - best way going forward is using invent to create merge requests - for now also send out an email to the konsole-devel ml after creating a merge request

https://invent.kde.org/kde/konsole/merge_requests