Toggle filtering of remote branches in DVCS Branch Manager
Needs ReviewPublic

Authored by christiant on Tue, Aug 6, 9:58 PM.

Details

Reviewers
apol
Summary

Add action/icon to filter remote branches in Branch Manager.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
christiant created this revision.Tue, Aug 6, 9:58 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptTue, Aug 6, 9:58 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
christiant requested review of this revision.Tue, Aug 6, 9:58 PM

I hope it is ok to add you as reviewer directly as you orchestrated the last commit from me in this area.

I'm really not sure what best practices are regarding icons and tool tips in KDE / Qt or UI in general.

christiant added a comment.EditedTue, Aug 6, 10:09 PM

I created some screenshots. Icon ist in the line edit (near the mouse pointer in the first picture).

No filtertext with remotesNo filtertext and no remotesSearch for master and no remotesSearch for master with remotes
apol added a comment.Mon, Aug 12, 11:24 AM

Maybe it would make sense to move the whole dialog into git plugin's code.

kdevplatform/vcs/dvcs/ui/branchmanager.cpp
126

This looks very git-specific to be in dvcs.

142

I don't think that's the right icon to show. Especially on a text field, it feels like we should have a password there.

I will look into it next week. The used icon is bogus. I was hoping for some input on that :) But i liked the idea of an icon in general.

With DVCS we alsways have remotes. Maybe I could have the filter string be part of the git plugin then and accessable via a virtual base class function. And only make it the icon visible if we have a DVCS specialization that has a filter?