Differential D22977

Make the Notifications KCM category headers look consistent with other Kirigami lists
ClosedPublic
Actions

Authored by GB_2 on Aug 6 2019, 7:52 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10384: Unify styles for lists and their buttons
Commits
R119:91ec99d32e90: Make the Notifications KCM category headers look consistent with other Kirigami…
Summary

Test Plan

Open the Notifications KCM and press the Configure... button.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 6 2019, 7:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2019, 7:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Aug 6 2019, 7:52 PM
ngraham accepted this revision.Aug 6 2019, 7:54 PM
ngraham added a subscriber: ngraham.

Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to change the appearance again.

This revision is now accepted and ready to land.Aug 6 2019, 7:54 PM
GB_2 added a comment.Aug 6 2019, 8:58 PM
In D22977#507716, @ngraham wrote:

Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to change the appearance again.

Yeah.

Closed by commit R119:91ec99d32e90: Make the Notifications KCM category headers look consistent with other Kirigami… (authored by GB_2). · Explain WhyAug 6 2019, 8:59 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Aug 7 2019, 6:51 AM

The vertical text alignment is quite off.

Revision Contents
Changeset List

Diff 63235

View Options

kcms/notifications/package/contents/ui/SourcesPage.qml

Loading...